Skip to content

Fix some miscellaneous clang-tidy errors#9999

Merged
bernhardmgruber merged 3 commits into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-07-17/fix-clang-tidy-errors
Jul 20, 2026
Merged

Fix some miscellaneous clang-tidy errors#9999
bernhardmgruber merged 3 commits into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-07-17/fix-clang-tidy-errors

Conversation

@Jacobfaib

Copy link
Copy Markdown
Contributor

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Jacobfaib Jacobfaib self-assigned this Jul 17, 2026
@Jacobfaib
Jacobfaib requested a review from a team as a code owner July 17, 2026 17:11
@Jacobfaib
Jacobfaib requested a review from ericniebler July 17, 2026 17:11
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jul 17, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7d5ab5ae-280f-4f87-a19c-29c343047704

📥 Commits

Reviewing files that changed from the base of the PR and between 8da74e0 and e38f515.

📒 Files selected for processing (1)
  • libcudacxx/include/cuda/std/__random/linear_congruential_engine.h
🚧 Files skipped from review as they are similar to previous changes (1)
  • libcudacxx/include/cuda/std/__random/linear_congruential_engine.h

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved sorting behavior by adjusting pivot partitioning and “equals-on” partition handling to better manage iterator progression.
    • Updated the random engine’s internal constant initialization to align with standards-compatible casting behavior.

Walkthrough

Sort partition searches now use explicit comparator checks and loop breaks. The linear congruential engine’s internal _Mp declaration removes a redundant qualifier and uses static_cast.

Changes

Sort partition loops

Layer / File(s) Summary
Partition search loop rewrites
libcudacxx/include/cuda/std/__algorithm/sort.h
Three partition helper loops replace compound while predicates with explicit iterator updates, comparator checks, and break statements.

Random engine declaration

Layer / File(s) Summary
Maximum-value constant declaration
libcudacxx/include/cuda/std/__random/linear_congruential_engine.h
The internal _Mp declaration removes the extra const qualifier and changes initialization to static_cast<result_type>(~0).

Suggested reviewers: ericniebler


Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 30d60885-515f-4613-bf4d-0021bc27c87c

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4a3bc and 8da74e0.

📒 Files selected for processing (2)
  • libcudacxx/include/cuda/std/__algorithm/sort.h
  • libcudacxx/include/cuda/std/__random/linear_congruential_engine.h

Comment thread libcudacxx/include/cuda/std/__random/linear_congruential_engine.h Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 1h 20m: Pass: 100%/120 | Total: 1d 02h | Max: 1h 10m | Hits: 95%/381914

See results here.

@bernhardmgruber
bernhardmgruber merged commit 7215b66 into NVIDIA:main Jul 20, 2026
139 of 141 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Jul 20, 2026
@Jacobfaib
Jacobfaib deleted the jacobf/2026-07-17/fix-clang-tidy-errors branch July 20, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants